Re: [V2 5/7] video: mmp: add pitch info in mmp_win structure
From: Daniel Drake <hidden>
Date: 2013-06-21 17:15:37
Also in:
linux-arm-kernel
On Mon, Jun 10, 2013 at 9:52 AM, Jett.Zhou [off-list ref] wrote:
quoted hunk
From: Jing Xiang <redacted> Add pitch length info of graphics/video layer for mmp_win, if it is YUV format of video layer, u/v pitch will non-zero. Signed-off-by: Jing Xiang <redacted> Signed-off-by: Jett.Zhou <redacted> --- include/video/mmp_disp.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)diff --git a/include/video/mmp_disp.h b/include/video/mmp_disp.h index b9dd1fb..462e3bd 100644 --- a/include/video/mmp_disp.h +++ b/include/video/mmp_disp.h@@ -91,6 +91,11 @@ struct mmp_win { u16 up_crop; u16 bottom_crop; int pix_fmt; + /* + * pitch[0]: graphics/video layer line length or y pitch + * pitch[1]/pitch[2]: video u/v pitch if non-zero + */ + u32 pitch[3]; };
Thanks for adding a comment here, but the meaning of this field is still not clear to me. In what case is pitch[0] line length, and in which case does it refer to y pitch? pitch[1] and pitch[2] refer to u/v pitch respectively, if their own values are non-zero? (or if not, what value does the "if non-zero" comment refer to?) I would recommend rolling this patch into the patch that actually makes use of this new field. Daniel