ARM: dts: Add DP PHY node to exynos5250.dtsi

Started by Jingoo Han on Jun 28, 2013 · 5 messages from 3 authors · Last reply Jun 28, 2013

Subsystems (1)

the rest

Maintainers (1)

Linus Torvalds

STALE4885d

open the first message on its own page

Jingoo Han Jun 28, 05:23 #

Message details and related content

Open message details and related content

Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
 arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -614,6 +614,12 @@
 		interrupts = <0 94 0>;
 	};
 
+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;
+	};
+
 	dp-controller {
 		compatible = "samsung,exynos5-dp";
 		reg = <0x145b0000 0x1000>;

@@ -623,11 +629,8 @@
 		clock-names = "dp";
 		#address-cells = <1>;
 		#size-cells = <0>;
-
-		dptx-phy {
-			reg = <0x10040720>;
-			samsung,enable-mask = <1>;
-		};
+		phys = <&dp_phy 0>;
+		phy-names = "dp";
 	};
 
 	fimd {

-- 
1.7.10.4

Kishon Vijay Abraham I replied to Jingoo Han Jun 28, 05:41 #

Message details and related content

Open message details and related content

Hi,

On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:

quoted hunk

Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
  arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
  1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -614,6 +614,12 @@
  		interrupts = <0 94 0>;
  	};

+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;

phy-cells can be '0' here since this phy_provider implements only one PHY.

Thanks
Kishon

Jingoo Han replied to Kishon Vijay Abraham I Jun 28, 05:58 #

Message details and related content

Open message details and related content

On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:

Hi,

On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:

quoted

Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
  arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
  1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -614,6 +614,12 @@
  		interrupts = <0 94 0>;
  	};

+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;

phy-cells can be '0' here since this phy_provider implements only one PHY.

Oh, thank you.
I will fix it.

Best regards,
Jingoo Han

Thanks
Kishon

Hui Wang replied to Jingoo Han Jun 28, 06:06 #

Message details and related content

Open message details and related content

On 06/28/2013 01:58 PM, Jingoo Han wrote:

On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:

quoted

Hi,

On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:

quoted

Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
   arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
   1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -614,6 +614,12 @@
   		interrupts = <0 94 0>;
   	};

+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;

phy-cells can be '0' here since this phy_provider implements only one PHY.

Oh, thank you.
I will fix it.

Don't forget to fix the corresponding description in the 
samsung,exynos5250-dp-video-phy.txt as well. :-)

Best regards,
Jingoo Han

quoted

Thanks
Kishon

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jingoo Han replied to Hui Wang Jun 28, 06:09 #

Message details and related content

Open message details and related content

On Friday, June 28, 2013 3:07 PM, Hui Wang wrote:

On 06/28/2013 01:58 PM, Jingoo Han wrote:

quoted

On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:

quoted

Hi,

On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:

quoted

Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
   arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
   1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -614,6 +614,12 @@
   		interrupts = <0 94 0>;
   	};

+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;

phy-cells can be '0' here since this phy_provider implements only one PHY.

Oh, thank you.
I will fix it.

Don't forget to fix the corresponding description in the
samsung,exynos5250-dp-video-phy.txt as well. :-)

Hi 

OK, I already fixed it. :)
Thank you for reminding me.

Best regards,
Jignoo Han

quoted

Best regards,
Jingoo Han

quoted

Thanks
Kishon

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help