Thread (6 messages) 6 messages, 5 authors, 2013-06-12

Re: [PATCH] backlight: add CONFIG_PM_SLEEP to suspend/resume functions

From: Shuah Khan <hidden>
Date: 2013-06-10 15:34:29
Also in: lkml

On 06/07/2013 04:25 AM, Arnd Bergmann wrote:
On Friday 07 June 2013 10:39:20 Jingoo Han wrote:
quoted
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
the CONFIG_PM_SLEEP is enabled.

drivers/video/backlight/backlight.c:211:12: warning: 'backlight_suspend' defined but not used [-Wunused-function]
drivers/video/backlight/backlight.c:225:12: warning: 'backlight_resume' defined but not used [-Wunused-function]

Signed-off-by: Jingoo Han <redacted>
I forgot:

Acked-by: Arnd Bergmann <arnd@arndb.de>
Jingoo Han, and Arnd,

Sorry I was on vacation all of last week. Thanks for fixing the problem. 
My apologies for introducing the warnings. I had CONFIG_PM and 
CONFIG_PM_SLEEP both enabled and didn't see this warning. I will be 
careful with subsequent patches in this area.

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research 
America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help