Re: [PATCH v3] backlight: Convert from Legacy pm ops to dev_pm_ops

On Friday, June 07, 2013 6:28 AM, Arnd Bergmann wrote:

On Monday 03 June 2013 13:10:10 Jingoo Han wrote:

quoted

On Sunday, June 02, 2013 8:07 AM, Shuah Khan wrote:

quoted

Convert drivers/video/backlight/class to use dev_pm_ops for power
management and remove Legacy PM ops hooks. With this change, backlight
class registers suspend/resume callbacks via class->pm (dev_pm_ops)
instead of Legacy class->suspend/resume. When __device_suspend() runs
call-backs, it will find class->pm ops for the backlight class.

Signed-off-by: Shuah Khan <redacted>
Cc: Shuah Khan <redacted>

CC'ed Andrew Morton,

It looks good.

Acked-by: Jingoo Han <redacted>

I'm getting this build warning now:

arnd@wuerfel:/git/arm-soc$ cat build/omap1_defconfig/faillog
/git/arm-soc/drivers/video/backlight/backlight.c:212:12: warning: 'backlight_suspend' defined but not
used [-Wunused-function]
 static int backlight_suspend(struct device *dev)
            ^
/git/arm-soc/drivers/video/backlight/backlight.c:226:12: warning: 'backlight_resume' defined but not
used [-Wunused-function]
 static int backlight_resume(struct device *dev)

Hi Arnd Bergmann,

I see what happens.
This build warning happens when CONFIG_PM is selected and
CONFIG_PM_SLEEP is not selected.

So, I will add '#ifdef CONFIG_PM_SLEEP' to './drivers/video/backlight/backlight.c'
and send it soon.
Thank you.

Best regards,
Jingoo Han

	Arnd