[PATCH v2] video: of_display_timing.h: Declare 'display_timing'

Subsystems: framebuffer layer, the rest

STALE4810d

2 messages, 2 authors, 2013-06-26 · open the first message on its own page

[PATCH v2] video: of_display_timing.h: Declare 'display_timing'

From: Fabio Estevam <hidden>
Date: 2013-06-26 13:34:25

Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes
the following build warning:

include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default]
include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Declare 'display_timing' to avoid the build warning.

Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- Add 'struct display_timing;' instead of '#include <video/display_timing.h>'
 include/video/of_display_timing.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h
index 6562ad9..79e6697 100644
--- a/include/video/of_display_timing.h
+++ b/include/video/of_display_timing.h
@@ -10,6 +10,7 @@
 #define __LINUX_OF_DISPLAY_TIMING_H
 
 struct device_node;
+struct display_timing;
 struct display_timings;
 
 #define OF_USE_NATIVE_MODE -1
-- 
1.8.1.2

Re: [PATCH v2] video: of_display_timing.h: Declare 'display_timing'

From: Tomi Valkeinen <hidden>
Date: 2013-06-26 13:36:27

On 26/06/13 16:34, Fabio Estevam wrote:
quoted hunk
Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes
the following build warning:

include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default]
include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Declare 'display_timing' to avoid the build warning.

Signed-off-by: Fabio Estevam <redacted>
---
Changes since v1:
- Add 'struct display_timing;' instead of '#include <video/display_timing.h>'
 include/video/of_display_timing.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h
index 6562ad9..79e6697 100644
--- a/include/video/of_display_timing.h
+++ b/include/video/of_display_timing.h
@@ -10,6 +10,7 @@
 #define __LINUX_OF_DISPLAY_TIMING_H
 
 struct device_node;
+struct display_timing;
 struct display_timings;
 
 #define OF_USE_NATIVE_MODE -1
Thanks. I've added this to fbdev-3.11 branch.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help