Re: [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata()
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Date: 2013-05-02 20:11:07
Also in:
linux-arm-kernel, linux-samsung-soc
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Date: 2013-05-02 20:11:07
Also in:
linux-arm-kernel, linux-samsung-soc
Hi Jingoo, On 05/02/2013 07:31 AM, Jingoo Han wrote:
On Saturday, April 27, 2013 5:02 AM, Sylwester Nawrocki wrote:quoted
quoted
driver_data field is being cleared by the driver core since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d device-core: Ensure drvdata = NULL when no driver is bound hence there is no need to do it in the driver's remove() callback.
How about eliminating platform_set_drvdata(pdev, NULL) in s3c24xxfb_probe() as well as s3c2410fb_remove()?
Ah, thanks for pointing out. Indeed, that could be dropped too, I've overlooked it somehow. Will update and resend this patch shortly. Regards, Sylwester