Re: [PATCH 1/2] video: exynos_dp: Add parsing of gpios pins to exynos-dp driver

Hi Vikas,

On Tuesday 14 of May 2013 18:25:51 Vikas Sajjan wrote:

 Adds GPIO parsing functionality for "LCD backlight" and "LCD enable"
 GPIO pins of exynos dp controller.

Signed-off-by: Vikas Sajjan <redacted>
---
 drivers/video/exynos/exynos_dp_core.c |   45
+++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)

I don't think that Exynos DP driver is right place for such code. Backlight 
and LCD drivers are responsible for backlight and LCD power control using 
backlight and LCD subsystems.

IMHO the correct solution would be to either extend existing backlight/lcd 
drivers found in drivers/video/backlight to support direct GPIO control and 
parse GPIO pins from device tree or create new gpio_bl and gpio_lcd drivers.

CCing Richard, Florian and linux-fbdev.

Best regards,
Tomasz