Thread (2 messages) 2 messages, 2 authors, 2013-03-11

Re: [PATCH] backlight: fix typo "MACH_SAM9...EK" three times

From: Jingoo Han <hidden>
Date: 2013-03-11 23:50:25
Also in: lkml

On Tuesday, March 12, 2013 5:47 AM, Paul Bolle wrote:
Fix three typos (originally) introduced by commit
a9a84c37d1ee50db8f3752b117caf2b48dcd4f8a ("atmel_lcdfb: backlight
control").

Signed-off-by: Paul Bolle <redacted>
CC'ed Andrew Morton.

It looks good.

Acked-by: Jingoo Han <redacted>


Best regards,
Jingoo Han

quoted hunk ↗ jump to hunk
---
0) Tested by grepping the tree.

1) So two of these typos were introduced in v2.6.25. (The third was
introduced in commit 915190f7d4f08e413e5fde6b0abcd5375aeacdf4 ("[ARM]
5614/1: at91: atmel_lcdfb: add at91sam9g10 support to atmel LCD
driver")). Checking these commits reveals that the default value of 'y'
has never been set automatically in all releases since v2.6.25! Perhaps
this line might as well be dropped.

 drivers/video/backlight/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index db10d01..a4481df 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -161,7 +161,7 @@ if BACKLIGHT_CLASS_DEVICE
 config BACKLIGHT_ATMEL_LCDC
 	bool "Atmel LCDC Contrast-as-Backlight control"
 	depends on FB_ATMEL
-	default y if MACH_SAM9261EK || MACH_SAM9G10EK || MACH_SAM9263EK
+	default y if MACH_AT91SAM9261EK || MACH_AT91SAM9G10EK || MACH_AT91SAM9263EK
 	help
 	  This provides a backlight control internal to the Atmel LCDC
 	  driver.  If the LCD "contrast control" on your board is wired
--
1.7.11.7
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help