Re: [PATCH 03/14] OMAPDSS: DSI: simplify dsi configuration

On 2013-03-20 13:24, Archit Taneja wrote:

On Friday 08 March 2013 05:22 PM, Tomi Valkeinen wrote:

quoted

We have a bunch of dsi functions that are used to do the basic
configuration for DSI. To simplify things, and to make sure we have all
the necessary information, create a single dsi config function, which
does the basic configuration.

I had split these funcs in the manner so that they could be converted
into generic output ops or something equivalent to what we anticipated
CDF to represent encoders. Hence, we may have to split this into smaller
funcs again later :p

Well, it was from the CDF discussions that this change arose. Everybody
wanted a simpler way than n+1 functions.

And I think it makes sense. It makes it possible to manage the
configuration as one "whole", instead of small bits that may have
interdependencies. E.g the size of the output affects video mode
calculations, so one had to make the calls in certain order. Now we have
all the needed information in one piece.

We could, perhaps, have common parts between different video busses, but
I'm not sure if configuration is one of those common parts.

Also, set_size and set_timings were 2 different ops for command and
video mode panels respectively. omapdss_dsi_set_size() also came in use
when we supported rotation in Taal. We have an equivalent func for rfbi.

Yep. I felt it's a bit confusing, so I just combined them. Even for
command mode some timing information is good (well, pixel clock), to
calculate proper DSI bus speed.

I think this also works in case of panel rotation. From DSS's point of
view (and that's what we're talking about when setting the timings)
there's no rotation. It's the panel's internal thing.

 Tomi