Re: [PATCH 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards
From: Andi Shyti <hidden>
Date: 2013-02-08 12:47:41
Also in:
linux-omap, lkml
From: Andi Shyti <hidden>
Date: 2013-02-08 12:47:41
Also in:
linux-omap, lkml
Hi,
Thanks for looking into
if you want you can put me in CC and I can review the next patches (perhaps V2 of the patches)
quoted
quoted
+ mutex_lock(&tc358765_i2c->xfer_lock); + ret = i2c_transfer(tc358765_i2c->client->adapter, &msg, 1); + mutex_unlock(&tc358765_i2c->xfer_lock);What about using smbus?OMAP2+ SoCs have full I2C controller so panel drivers traditionally use I2C. Since implementation is OMAP-specific, I don't think we need to use smbus here. Also please look at other panels implementation: drivers/video/omap2/displays/panel-tfp410.c drivers/video/omap2/displays/panel-picodlp.c
Yeah, it's the same problem with other i2c drivers, they should be written to be working as much as possible with the emulated smbus. I don't actually know the internals of the omap2 driver controller, but not being able to use smbus, definitely sucks!
Will be fixed in next patchset
What about sending a patch V2? :) Andi