Re: BUG: circular locking dependency detected
From: Daniel Vetter <hidden>
Date: 2013-01-31 08:21:19
Also in:
dri-devel, lkml
On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman [off-list ref] wrote:
On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote:quoted
On Thu, Jan 31, 2013 at 11:13 AM, Russell King [off-list ref] wrote:quoted
Which may or may not be a good thing depending how you look at it; it means that once your kernel blanks, you get a lockdep dump. At that point you lose lockdep checking for everything else because lockdep disables itself after the first dump.Fair enough, we may want to revert the lockdep checking for console_lock, and make re-enabling it part of the patch-series that fixes the locking. Daniel/Dave? Does that sound reasonable?
Yeah, sounds good.
Reverting the patch is fine with me. Just let me know so I can queue it up again for 3.9.
Can you please also pick up the (currently) three locking fixups around fbcon? Just so that we don't repeat the same fun where people complain about lockdep splats, but the fixes are stuck somewhere. And I guess Dave would be happy to not end up as fbcon maintainer ;-) He has a git branch with them at http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes though I have a small bikeshed on his last patch pending. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch