Thread (14 messages) flat view 14 messages, 2 authors, 2013-01-31

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

From: Thierry Reding <hidden>
Date: 2013-01-28 21:01:49
Also in: linux-devicetree, lkml

On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote:
It is expected that board files would have:
static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, };

static struct platform_pwm_backlight_data bl_data = {
	.levels = bl_levels,
	.max_brightness = ARRAY_SIZE(bl_levels),
	.dft_brightness = 4,
	.pwm_period_ns = 7812500,
};

In this case the max_brightness would be out of range in the levels array.
Decrement the received max_brightness in every case (DT or non DT) when the
levels has been provided.
What's wrong with specifying .max_brightness = ARRAY_SIZE(bl_levels) - 1
instead?

Thierry

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help