Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

On 01/21/2013 04:52 PM, Marc Dietrich wrote:

Hi,

quoted

quoted

diff --git a/drivers/video/backlight/pwm_bl_tegra.c

b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644
index 0000000..8f2195b

--- /dev/null
+++ b/drivers/video/backlight/pwm_bl_tegra.c

So according to the filename, I think we can put all tegra boards codes
here, right? Just like what you do for Ventana, if I wanna add support
for cardhu, I can define similar functions -- let's say "init_cardhu",
"exit_cardhu", "notify_cardhu" and "notify_after_cardhu", right?

But I think if we do in this way, the file will become very long soon.
And there are a lot of redundant codes in it. So do you have any
suggestions?

I think we (for PAZ00) will just reuse the ventana code which is sufficient 
for us. But adding "pwm-backlight-ventana" to our DTS may look a bit strange. 
On the other hand, I guess that's why the property is called "compatible".

Ah, yeah, that looks strange. :)
Okay, so I know why Alex wants to use panel name while not board name...

Marc