Re: [PATCH v2 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling

Anatolij Gustschin wrote:

Disabling the interrupts in fsl_diu_release() must happen only if all
other AOIs are closed. Otherwise closing an overlay plane will disable
the interrupts even if the primary frame buffer plane is opened. Add
an appropriate check in the release function.

I thought the release function is only called when the driver is unloaded. 
  Wouldn't the framebuffers all already be closed by then?

+static inline void fsl_diu_enable_interrupts(struct fsl_diu_data *data)
+{
+	u32 int_mask = INT_UNDRUN; /* enable underrun detection */
+
+	if (IS_ENABLED(CONFIG_NOT_COHERENT_CACHE))
+		int_mask |= INT_VSYNC; /* enable vertical sync */

Why did you turn this into a run-time check?

-- 
Timur Tabi