Re: [PATCH 2/2] drivers/video: fsl-diu-fb: fix bugs in interrupt handling

From
Anatolij Gustschin <agust@denx.de>
Date
2013-01-17 23:11:07
Reply to
Anatolij Gustschin, 2013-01-17
On Thu, 17 Jan 2013 16:20:04 -0600
Timur Tabi [off-list ref] wrote:
...
This is why you need hacks like can_handle_irq.  So I'm not crazy about
this patch.  I think you need to get rid of can_handle_irq and allow the
interrupt handler to be registered before the hardware is initialized.
It makes sense. More testing shows that disabling interrupts in
fsl_diu_release() needs to be fixed, too. If the fb0 plane is opened
(i.e. by fbcon) and another app opens an overlay plane i.e. on /dev/fb1
and then closes it, the diu interrupts will be disabled, even though the
first plane is still opened.

Thanks,

Anatolij
Thread (3 messages) 3 messages, 2 authors, last reply 2013-01-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help