Re: [patch] OMAPDSS: reading past end of array in dispc_dump_regs()
From: Tomi Valkeinen <hidden>
Date: 2012-12-17 12:09:00
Also in:
kernel-janitors, linux-omap
On 2012-12-14 17:01, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
We added another kind of plane in 66a0f9e4ac "OMAPDSS: Use WB fifo for GFX overlay" so this array needs a new entry as well. Signed-off-by: Dan Carpenter <redacted> --- Static checker work. I don't have a way to test this.diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c index fedbd2c..bfe62cc 100644 --- a/drivers/video/omap2/dss/dispc.c +++ b/drivers/video/omap2/dss/dispc.c@@ -3163,6 +3163,7 @@ static void dispc_dump_regs(struct seq_file *s) [OMAP_DSS_VIDEO1] = "VID1", [OMAP_DSS_VIDEO2] = "VID2", [OMAP_DSS_VIDEO3] = "VID3", + [OMAP_DSS_WB] = "WB", }; const char **p_names;
We don't count WB as an overlay currently, as it's handled a bit differently, so we never try to access that array with OMAP_DSS_WB. We don't actually dump any WB related registers currently, it seems. So I think I'll leave this out for now. Why does the static checker think OMAP_DSS_WB is needed in the array? I wonder if I'm reading the code wrong, and we indeed do access the array with OMAP_DSS_WB... Tomi
Attachments
- signature.asc [application/pgp-signature] 899 bytes