Re: [PATCH v9 5/6] drm_modes: add videomode helpers
From: Thierry Reding <hidden>
Date: 2012-11-14 12:49:44
Also in:
dri-devel, linux-devicetree, linux-media
On Wed, Nov 14, 2012 at 12:43:22PM +0100, Steffen Trumtrar wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
quoted hunk ↗ jump to hunk
@@ -504,6 +505,41 @@ drm_gtf_mode(struct drm_device *dev, int hdisplay, int vdisplay, int vrefresh, } EXPORT_SYMBOL(drm_gtf_mode); +#if IS_ENABLED(CONFIG_VIDEOMODE) +int display_mode_from_videomode(struct videomode *vm, struct drm_display_mode *dmode)
Given that this is still a DRM core function, maybe it should get a drm_ prefix? Also the line is too long, so you may want to wrap the argument list. Thierry
Attachments
- (unnamed) [application/pgp-signature] 836 bytes