Re: [PATCH v8 1/6] video: add display_timing and videomode

On Wed, Nov 14, 2012 at 12:02:15PM +0100, Thierry Reding wrote:

On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote:

quoted

On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote:

quoted

On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote:
[...]

quoted

diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c

[...]

quoted

+void display_timings_release(struct display_timings *disp)
+{
+	if (disp->timings) {
+		unsigned int i;
+
+		for (i = 0; i < disp->num_timings; i++)
+			kfree(disp->timings[i]);
+		kfree(disp->timings);
+	}
+	kfree(disp);
+}

I think this is still missing an EXPORT_SYMBOL_GPL. Otherwise it can't
be used from modules.

Thierry

Yes. Just in time. I was just starting to type the send-email command ;-)

Great! In that case don't forget to also look at my other email before
sending. =)

Sure.


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

On Wed, Nov 14, 2012 at 12:10:15PM +0100, Steffen Trumtrar wrote:

On Wed, Nov 14, 2012 at 12:02:15PM +0100, Thierry Reding wrote:

quoted

On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote:

quoted

On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote:

quoted

On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote:
[...]

quoted

diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c

[...]

quoted

+void display_timings_release(struct display_timings *disp)
+{
+	if (disp->timings) {
+		unsigned int i;
+
+		for (i = 0; i < disp->num_timings; i++)
+			kfree(disp->timings[i]);
+		kfree(disp->timings);
+	}
+	kfree(disp);
+}

I think this is still missing an EXPORT_SYMBOL_GPL. Otherwise it can't
be used from modules.

Thierry

Yes. Just in time. I was just starting to type the send-email command ;-)

Great! In that case don't forget to also look at my other email before
sending. =)

Sure.

Besides those comments (and those from other people) I think your
patchset is in pretty good shape. Have you thought about how and when
you want to get things merged?

Thierry