Re: [PATCH 1/2 v6] of: add helper to parse display timings

On Thu, Oct 11, 2012 at 09:31:18PM +0200, Thierry Reding wrote:

On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote:

quoted

On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote:

quoted

On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote:

[...]

quoted

quoted

quoted

+
+	disp->num_timings = 0;
+
+	for_each_child_of_node(timings_np, entry) {
+		disp->num_timings++;
+	}

No need for { }

Okay.

Or you could just use of_get_child_count().

Thierry

Ah, very nice. That's definitely better. Didn't know about that function.

Thanks,
Steffen


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |