Re: [PATCH V4 2/2] video: exynos_dp: device tree documentation

On 10/11/2012 08:50 AM, Ajay kumar wrote:

quoted

quoted

+     -samsung,interlaced:
+             Interlace scan mode.
+                     Progressive if defined, Interlaced if not defined
+     -samsung,v_sync_polarity:
+             VSYNC polarity configuration.
+                     High if defined, Low if not defined
+     -samsung,h_sync_polarity:
+             HSYNC polarity configuration.
+                     High if defined, Low if not defined

So there is no common video bindings for things like these two ?
In V4L2 we decided to use vsync-active, hsync-active [1], the video
timings bindings [2] use hsync-active-high, hsync-active-high boolean
properties. Perhaps it is worth to pick some of those standard
definitions and use instead of the vendor specific ones ?

hsync-active-high and vsync-active-high seems to hold good in our case.
Also, are you asking us to just use only the standard names or use standard
helper functions as well? Since we use only hsync and vsync polarity and no
other LCD timing properties, I think we need not use standard helper functions
for parsing display timings!

My point was just to use common property names where possible. Any parsing
helpers could be created afterwards, if you would rather avoid doing that
right now. BTW, it seems 'interlaced' could also be reused.

...

quoted

[1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg52743.html
[2] http://www.mail-archive.com/linux-media@vger.kernel.org/msg53323.html

Thanks,
Sylwester