da8xx: Fix revision check on the da8xx driver

Started by Pantelis Antoniou on Oct 30, 2012 · 4 messages from 3 authors · Last reply Dec 4, 2012

Subsystems (2)

Maintainers (2)

STALE5092d

open the first message on its own page

Message details and related content
The revision check fails for the beaglebone; Add new revision ID.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/da8xx-fb.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
 		lcd_revision = LCD_VERSION_1;
 		break;
 	case 0x4F200800:
+	case 0x4F201000:
 		lcd_revision = LCD_VERSION_2;
 		break;
 	default:
-- 
1.7.12
Message details and related content
On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
quoted hunk
The revision check fails for the beaglebone; Add new revision ID.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/da8xx-fb.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
 		lcd_revision = LCD_VERSION_1;
 		break;
 	case 0x4F200800:
+	case 0x4F201000:
Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
with to one read(0x4F200800) on emulator platform.

Acked-by: Manjunathappa, Prakash <redacted>
 		lcd_revision = LCD_VERSION_2;
 		break;
 	default:
-- 
1.7.12

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Message details and related content
Hi Tomi,

On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
quoted
The revision check fails for the beaglebone; Add new revision ID.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/da8xx-fb.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
 		lcd_revision = LCD_VERSION_1;
 		break;
 	case 0x4F200800:
+	case 0x4F201000:
Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
with to one read(0x4F200800) on emulator platform.

Acked-by: Manjunathappa, Prakash <redacted>
This patch is necessary for am335x FB, I could not see in your for-next branch,
could you please consider this patch for 3.8 merge window. There are no pending
review comments on this.

Thanks,
Prakash
quoted
 		lcd_revision = LCD_VERSION_2;
 		break;
 	default:
-- 
1.7.12

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Message details and related content
On 2012-12-04 08:36, Manjunathappa, Prakash wrote:
Hi Tomi,

On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
quoted
On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
quoted
The revision check fails for the beaglebone; Add new revision ID.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/da8xx-fb.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
 		lcd_revision = LCD_VERSION_1;
 		break;
 	case 0x4F200800:
+	case 0x4F201000:
Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
with to one read(0x4F200800) on emulator platform.

Acked-by: Manjunathappa, Prakash <redacted>
This patch is necessary for am335x FB, I could not see in your for-next branch,
I have only applied the patches that have been sent to me.
could you please consider this patch for 3.8 merge window. There are no pending
review comments on this.
Applied.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help