Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver

Hi,

On Friday 28 of September 2012 09:11:09 Jingoo Han wrote:

On Thursday, September 27, 2012 10:45 PM Sylwester Nawrocki wrote

quoted

quoted

+Example:
+
+SOC specific portion:
+	dptx_phy: dptx_phy@0x10040720 {
+		compatible = "samsung,dp-phy";
+		samsung,dptx_phy_reg =<0x10040720>;
+		samsung,enable_bit =<1>;
+	};
+
+	display-port-controller {
+		compatible = "samsung,exynos5-dp";
+		reg =<0x145B0000 0x10000>;
+		interrupts =<10 3>;
+		interrupt-parent =<&combiner>;
+		dp_phy =<&dptx_phy>;

Shouldn't it be "samsung,dp_phy" ?

Do you mean this ? It is not working.
+		dp_phy = "samsung,dp_phy";

I believe he meant:

-+		dp_phy =<&dptx_phy>;
++		samsung,dp_phy =<&dptx_phy>;

to mark that this is a Samsung-specific property.

Best regards,
Tomasz Figa