[PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

Subsystems: framebuffer layer, the rest

STALE5062d

3 messages, 2 authors, 2012-10-09 · open the first message on its own page

[PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

From: Shubhrajyoti D <hidden>
Date: 2012-09-17 15:55:42 

Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.

Thanks to Julia Lawall [off-list ref]  for automating the conversion

Signed-off-by: Shubhrajyoti D <redacted>
---
the cocci file was posted
http://www.mail-archive.com/cocci@diku.dk/msg02753.html

 drivers/video/matrox/matroxfb_maven.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
index 217678e..fb5c123 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {
 
 static int maven_get_reg(struct i2c_client* c, char reg) {
 	char dst;
-	struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), &reg },
-				 { c->addr, I2C_M_RD | I2C_M_NOSTART, sizeof(dst), &dst }};
+	struct i2c_msg msgs[] = {{
+					.addr = c->addr,
+					.flags = I2C_M_REV_DIR_ADDR,
+					.len = sizeof(reg),
+					.buf = &reg
+				},
+				{
+					.addr = c->addr,
+					.flags = I2C_M_RD | I2C_M_NOSTART,
+					.len = sizeof(dst),
+					.buf = &dst
+				}
+	};
 	s32 err;
 
 	err = i2c_transfer(c->adapter, msgs, 2);
-- 
1.7.5.4

Re: [PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

From: Shubhrajyoti Datta <hidden>
Date: 2012-09-25 03:54:49 

On Mon, Sep 17, 2012 at 9:25 PM, Shubhrajyoti D [off-list ref] wrote:
Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.

Thanks to Julia Lawall [off-list ref]  for automating the conversion
ping.
quoted hunk
Signed-off-by: Shubhrajyoti D <redacted>
---
the cocci file was posted
http://www.mail-archive.com/cocci@diku.dk/msg02753.html

 drivers/video/matrox/matroxfb_maven.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
index 217678e..fb5c123 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {

 static int maven_get_reg(struct i2c_client* c, char reg) {
        char dst;
-       struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), &reg },
-                                { c->addr, I2C_M_RD | I2C_M_NOSTART, sizeof(dst), &dst }};
+       struct i2c_msg msgs[] = {{
+                                       .addr = c->addr,
+                                       .flags = I2C_M_REV_DIR_ADDR,
+                                       .len = sizeof(reg),
+                                       .buf = &reg
+                               },
+                               {
+                                       .addr = c->addr,
+                                       .flags = I2C_M_RD | I2C_M_NOSTART,
+                                       .len = sizeof(dst),
+                                       .buf = &dst
+                               }
+       };
        s32 err;

        err = i2c_transfer(c->adapter, msgs, 2);
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

From: Shubhrajyoti D <hidden>
Date: 2012-10-09 11:49:48 

Convert the struct i2c_msg initialization to C99 format. This makes
maintaining and editing the code simpler. Also helps once other fields
like transferred are added in future.

Thanks to Julia Lawall [off-list ref]  for automating the conversion

Signed-off-by: Shubhrajyoti D <redacted>
---
 drivers/video/matrox/matroxfb_maven.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
index 217678e..fb5c123 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -137,8 +137,19 @@ static int* get_ctrl_ptr(struct maven_data* md, int idx) {
 
 static int maven_get_reg(struct i2c_client* c, char reg) {
 	char dst;
-	struct i2c_msg msgs[] = {{ c->addr, I2C_M_REV_DIR_ADDR, sizeof(reg), &reg },
-				 { c->addr, I2C_M_RD | I2C_M_NOSTART, sizeof(dst), &dst }};
+	struct i2c_msg msgs[] = {{
+					.addr = c->addr,
+					.flags = I2C_M_REV_DIR_ADDR,
+					.len = sizeof(reg),
+					.buf = &reg
+				},
+				{
+					.addr = c->addr,
+					.flags = I2C_M_RD | I2C_M_NOSTART,
+					.len = sizeof(dst),
+					.buf = &dst
+				}
+	};
 	s32 err;
 
 	err = i2c_transfer(c->adapter, msgs, 2);
-- 
1.7.5.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help