Thread (16 messages) 16 messages, 4 authors, 2012-09-07

Re: [PATCH v5 2/4] pwm_backlight: use power sequences

From: Stephen Warren <hidden>
Date: 2012-09-05 17:25:34
Also in: linux-devicetree, linux-tegra, lkml

On 08/31/2012 05:34 AM, Alexandre Courbot wrote:
Make use of the power sequences specified in the device tree or platform
data to control how the backlight is powered on and off.
quoted hunk ↗ jump to hunk
+++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
 Optional properties:
-  - pwm-names: a list of names for the PWM devices specified in the
-               "pwms" property (see PWM binding[0])
+  - pwm-names: name for the PWM device specified in the "pwms" property (see PWM
+      binding[0]). Necessary if power sequences are used
So this implies that power sequence are completely optional in the pwm
binding...
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
 config BACKLIGHT_PWM
 	tristate "Generic PWM based Backlight Driver"
 	depends on PWM
+	select POWER_SEQ
... but that implies they're basically mandatory.

Briefly looking at the code, power sequences don't appear to be
optional, at least for the DT case, so perhaps you just need to update
the documentation to make "pwm-names" non-optional?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help