[PATCH v2 1/2] video: exynos_mipi_dsi: Remove unused code

Subsystems: framebuffer layer, the rest

STALE5078d REVIEWED: 2 (2M)

1 review trailer.

3 messages, 3 authors, 2012-09-23 · open the first message on its own page

[PATCH v2 1/2] video: exynos_mipi_dsi: Remove unused code

From: Sachin Kamat <hidden>
Date: 2012-09-21 05:18:46

This code is never executed and hence removed.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: Inki Dae <inki.dae@samsung.com>

---
 drivers/video/exynos/exynos_mipi_dsi_common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 47b533a..7cc4113 100644
--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c

@@ -288,9 +288,6 @@ int exynos_mipi_dsi_wr_data(struct mipi_dsim_device *dsim, unsigned int data_id,
 		mutex_unlock(&dsim->lock);
 		return -EINVAL;
 	}
-
-	mutex_unlock(&dsim->lock);
-	return 0;
 }
 
 static unsigned int exynos_mipi_dsi_long_data_rd(struct mipi_dsim_device *dsim,

-- 
1.7.4.1

RE: [PATCH v2 1/2] video: exynos_mipi_dsi: Remove unused code

From: Inki Dae <inki.dae@samsung.com>
Date: 2012-09-21 06:01:23

Acked-by: Inki Dae <inki.dae@samsung.com>

quoted hunk

-----Original Message-----
From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
Sent: Friday, September 21, 2012 2:07 PM
To: linux-fbdev@vger.kernel.org
Cc: inki.dae@samsung.com; FlorianSchandinat@gmx.de;
sachin.kamat@linaro.org; patches@linaro.org
Subject: [PATCH v2 1/2] video: exynos_mipi_dsi: Remove unused code

This code is never executed and hence removed.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: Inki Dae <inki.dae@samsung.com>

---
 drivers/video/exynos/exynos_mipi_dsi_common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c

b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 47b533a..7cc4113 100644

--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c

@@ -288,9 +288,6 @@ int exynos_mipi_dsi_wr_data(struct mipi_dsim_device

*dsim, unsigned int data_id,
 		mutex_unlock(&dsim->lock);
 		return -EINVAL;
 	}
-
-	mutex_unlock(&dsim->lock);
-	return 0;
 }

 static unsigned int exynos_mipi_dsi_long_data_rd(struct mipi_dsim_device
*dsim,
--
1.7.4.1

Re: [PATCH v2 1/2] video: exynos_mipi_dsi: Remove unused code

From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2012-09-23 19:54:17

Applied both patches of this series.


Thanks,

Florian Tobias Schandinat


On 09/21/2012 05:06 AM, Sachin Kamat wrote:

quoted hunk

This code is never executed and hence removed.

Signed-off-by: Sachin Kamat <redacted>
Acked-by: Inki Dae <inki.dae@samsung.com>

---
 drivers/video/exynos/exynos_mipi_dsi_common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 47b533a..7cc4113 100644
--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c

@@ -288,9 +288,6 @@ int exynos_mipi_dsi_wr_data(struct mipi_dsim_device *dsim, unsigned int data_id,
 		mutex_unlock(&dsim->lock);
 		return -EINVAL;
 	}
-
-	mutex_unlock(&dsim->lock);
-	return 0;
 }
 
 static unsigned int exynos_mipi_dsi_long_data_rd(struct mipi_dsim_device *dsim,

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help