Re: [PATCH 1/6] OMAPDSS: add omapdss_version

From
Archit Taneja <hidden>
Date
2012-09-28 11:12:21
Also in
linux-omap
Reply to
Tomi Valkeinen, 2012-09-28
On Friday 28 September 2012 04:05 PM, Tomi Valkeinen wrote:
quoted hunk ↗ jump to hunk
Add new enum, omapdss_version, that is used to tell which DSS hardware
version the SoC has. This enum is initialized during platform init, and
passed in the platform data to omapdss driver.

Note that the versions are not "continuous", that is, you cannot check
if the version is less or greater than something, but you need to check
for exact version match. In other words, this is invalid:

/* test if DSS is 3630 or earlier */
if (ver <= OMAPDSS_VER_OMAP3630)
	...

Signed-off-by: Tomi Valkeinen <redacted>
---
  arch/arm/mach-omap2/display.c |   38 ++++++++++++++++++++++++++++++++++++++
  include/video/omapdss.h       |   14 ++++++++++++++
  2 files changed, 52 insertions(+)
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index ee40739..33555da 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -284,6 +284,35 @@ err:
  	return ERR_PTR(r);
  }

+static enum omapdss_version omap_display_get_version(void)
We could add a __init for this function?

Archit
Thread (11 messages) 11 messages, 3 authors, last reply 2012-10-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help