Thread (4 messages) 4 messages, 3 authors, 2012-09-17

Re: [PATCH Re-send] pwm-backlight: Use devm_pwm_get in pwm_bl.c

From: Sachin Kamat <hidden>
Date: 2012-09-17 09:52:01

On 17 September 2012 15:03, Thierry Reding
[off-list ref] wrote:
On Mon, Sep 17, 2012 at 11:50:47AM +0530, Sachin Kamat wrote:
quoted
This file already makes use of device managed functions.
Convert pwm_get() too to use it.
I find this description a bit confusing. pwm_get() is not converted, but
rather the driver is converted to use devm_pwm_get() instead of
pwm_get().

How about this:

        pwm-backlight: Use devm_pwm_get() instead of pwm_get()

        Managed versions of the pwm_get() and pwm_put() functions were recently
        added to the PWM framework. They can be used to simplify cleanup in the
        error paths and the device removal callback.

If that's okay with you, I can just replace it before pushing so there's
no need for you to resend.
Your description sounds good. Please go ahead with it.
Thanks
Thierry


-- 
With warm regards,
Sachin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help