Jingoo Han wrote:

On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:

quoted

Hello Jingoo Han,

On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han [off-list ref] wrote:

quoted

On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:

quoted

Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
to include/video/samsung_fimd.h

Signed-off-by: Leela Krishna Amudala <redacted>
---
 arch/arm/plat-samsung/include/plat/regs-fb-v4.h |  159 -------
 arch/arm/plat-samsung/include/plat/regs-fb.h    |  403

---------------

--

quoted

quoted

quoted

 include/video/samsung_fimd.h                    |  533

+++++++++++++++++++++++

quoted

quoted

quoted

 3 files changed, 533 insertions(+), 562 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
 create mode 100644 include/video/samsung_fimd.h

+*/
+
+/*FIMD V8 REG OFFSET */
+#define FIMD_V8_VIDTCON0     (0x20010)
+#define FIMD_V8_VIDTCON1     (0x20014)
+#define FIMD_V8_VIDTCON2     (0x20018)
+#define FIMD_V8_VIDTCON3     (0x2001C)
+#define FIMD_V8_VIDCON1              (0x20004)

How about using soc_is_exynos5250()?

+#define VIDTCON0				(soc_is_exynos5250() ? \
+						(0x20010) : (0x10))

In this case, the FIMD driver does not need to change.
Also, one binary is available.

I don't agree. Do you _really_ think the address will be fixed on other SoCs
including upcoming SoCs? I'd prefer to use the version or something for it.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.