Re: [PATCH 4/4] ARM: dts: mxs: add oled support for the cfa-10036
STALE5150d
From: Shawn Guo <hidden>
Date: 2012-08-23 14:45:45
Also in:
linux-arm-kernel
On Thu, Aug 23, 2012 at 10:42:31AM +0200, Maxime Ripard wrote:
Signed-off-by: Maxime Ripard <redacted> Cc: Brian Lilly <redacted> --- arch/arm/boot/dts/imx28-cfa10036.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
Looks mostly good, but I have to postpone it until driver part gets accepted. Some minor comments below.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts index c03a577..92784a9 100644 --- a/arch/arm/boot/dts/imx28-cfa10036.dts +++ b/arch/arm/boot/dts/imx28-cfa10036.dts@@ -33,11 +33,31 @@ }; apbx@80040000 { + pwm: pwm@80064000 { + pinctrl-names = "default"; + pinctrl-0 = <&pwm4_pins_a>; + status = "okay"; + }; + duart: serial@80074000 { pinctrl-names = "default"; pinctrl-0 = <&duart_pins_b>; status = "okay"; }; + + i2c0: i2c@80058000 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins_b>; + status = "okay"; + + ssd1307: oled@3c { + compatible = "solomon,ssd1307fb-i2c"; + reg = <0x3c>; + pwms = <&pwm 4 3000>; + oled-reset-gpio = <&gpio2 7 1>;
The idiom of naming gpio in DT is *-gpios, even though most of times there is only one pin.
+ oled-reset-active-low;
I would drop oled- prefix for above two properties. Regards, Shawn
+ }; + }; }; }; -- 1.7.9.5