RE: [PATCH V2 5/5] arm: samsung: delete frame buffer header files from platform

Sylwester Nawrocki wrote:

Hi,

On 08/01/2012 11:39 AM, Kukjin Kim wrote:

quoted

Leela Krishna Amudala wrote:

quoted

On Wed, Aug 1, 2012 at 7:34 AM, Kukjin Kim [off-list ref]

wrote:

quoted

quoted

quoted

Leela Krishna Amudala wrote:

quoted

The FIMD register headers are moved to include/video/
hence, deleting these files from platform side

Signed-off-by: Leela Krishna Amudala <redacted>
---
 arch/arm/plat-samsung/include/plat/regs-fb-v4.h |  159 ---------
 arch/arm/plat-samsung/include/plat/regs-fb.h    |  403

-------------------

quoted

----
 2 files changed, 0 insertions(+), 562 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h

No. This should be squashed into first patch on this series. See

below.

quoted

quoted

quoted

 arch/arm/plat-samsung/include/plat/regs-fb-v4.h    |  159
--------------------
 .../plat/regs-fb.h => include/video/samsung_fimd.h |  145
++++++++++++++++--
 2 files changed, 134 insertions(+), 170 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
 rename arch/arm/plat-samsung/include/plat/regs-fb.h =>
include/video/samsung_fimd.h (74%)

If I squash it with the first patch and if somebody set that as a head
commit, it will break the build. Hence, splitted it up from the first
patch.

NACK. your changes are not adding just moving. So should be squashed. If
required, you could create just one patch for moving them, probably,

1st,

quoted

3rd, 4th and 5th patches into one patch.

Yes, this patch series is mainly moving files around. But to avoid git
bisect breakage, it should be split as it is done now, or the whole
series should be squashed into one patch. The latter might be even easier
to handle, but having a single patch touching arch/arm/ and drivers/
might not be a good idea. If you're fine handling that, then we just
need to squash this series into single patch.
It just need to be ensured, IMO, there is no bisection breakage.

I know you meant. But we don't need to keep the changes 'adding and
removing' for just moving on this.

I commented on 0/5 patch in this series before, if this is ready, I will
create topic branch so that it could be merged into both mine and Florian's.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.