Re: [patch] video: mb862xxfb: prevent divide by zero bug

Started by Anatolij Gustschin on Aug 18, 2012

open the first message on its own page

Message details and related content
On Sat, 18 Aug 2012 18:55:41 +0300
Dan Carpenter [off-list ref] wrote:
Do a sanity check on these before using them as divisors.

Signed-off-by: Dan Carpenter <redacted>
Acked-by: Anatolij Gustschin <agust@denx.de>
quoted hunk
diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
index 00ce1f3..57d940b 100644
--- a/drivers/video/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/mb862xx/mb862xxfbdrv.c
@@ -328,6 +328,8 @@ static int mb862xxfb_ioctl(struct fb_info *fbi, unsigned int cmd,
 	case MB862XX_L1_SET_CFG:
 		if (copy_from_user(l1_cfg, argp, sizeof(*l1_cfg)))
 			return -EFAULT;
+		if (l1_cfg->dh = 0 || l1_cfg->dw = 0)
+			return -EINVAL;
 		if ((l1_cfg->sw >= l1_cfg->dw) && (l1_cfg->sh >= l1_cfg->dh)) {
 			/* downscaling */
 			outreg(cap, GC_CAP_CSC,
Thanks,

Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help