Thread (2 messages) flat view 2 messages, 2 authors, 2012-08-23
STALE5145d

[patch] video: mb862xxfb: prevent divide by zero bug

From: Dan Carpenter <hidden>
Date: 2012-08-18 15:55:41
Also in: kernel-janitors, linux-devicetree
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

Do a sanity check on these before using them as divisors.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
index 00ce1f3..57d940b 100644
--- a/drivers/video/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/mb862xx/mb862xxfbdrv.c
@@ -328,6 +328,8 @@ static int mb862xxfb_ioctl(struct fb_info *fbi, unsigned int cmd,
 	case MB862XX_L1_SET_CFG:
 		if (copy_from_user(l1_cfg, argp, sizeof(*l1_cfg)))
 			return -EFAULT;
+		if (l1_cfg->dh = 0 || l1_cfg->dw = 0)
+			return -EINVAL;
 		if ((l1_cfg->sw >= l1_cfg->dw) && (l1_cfg->sh >= l1_cfg->dh)) {
 			/* downscaling */
 			outreg(cap, GC_CAP_CSC,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help