Re: [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code
flat view
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2012-08-23 20:48:33
Also in:
kernel-janitors, lkml
On 08/19/2012 08:44 AM, Julia Lawall wrote:
From: Julia Lawall <redacted> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <redacted>
Applied. Thanks, Florian Tobias Schandinat
quoted hunk ↗ jump to hunk
--- drivers/video/sunxvr2500.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/video/sunxvr2500.c b/drivers/video/sunxvr2500.c index 5848436..7fbcba8 100644 --- a/drivers/video/sunxvr2500.c +++ b/drivers/video/sunxvr2500.c@@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev, sp->fb_size = info->fix.line_length * sp->height; sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size); - if (!sp->fb_base) + if (!sp->fb_base) { + err = -ENOMEM; goto err_release_pci; + } err = s3d_set_fbinfo(sp); if (err)