Thread (3 messages) 3 messages, 2 authors, 2012-10-13
STALE5023d

[PATCH RESEND] video/udlfb: fix line counting in fb_write

From: Alexander Holler <hidden>
Date: 2012-08-14 07:11:31
Also in: lkml
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Holler <redacted>
---
  drivers/video/udlfb.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index a159b63..85d8110 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -647,7 +647,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info, 
const char __user *buf,
  	result = fb_sys_write(info, buf, count, ppos);
   	if (result > 0) {
-		int start = max((int)(offset / info->fix.line_length) - 1, 0);
+		int start = max((int)(offset / info->fix.line_length), 0);
  		int lines = min((u32)((result / info->fix.line_length) + 1),
  				(u32)info->var.yres);
  -- 1.7.6.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help