[PATCH] fbdev: Make the switch from generic to native driver less alarming

Subsystems: framebuffer layer, the rest

STALE4588d

4 messages, 3 authors, 2014-03-21 · open the first message on its own page

[PATCH] fbdev: Make the switch from generic to native driver less alarming

From: Adam Jackson <hidden>
Date: 2012-08-17 17:10:44

Calling this "conflicting" just makes people think there's a problem
when there's not.

Signed-off-by: Adam Jackson <redacted>
---
 drivers/video/fbmem.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 0dff12a..42be978 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1582,8 +1582,7 @@ static void do_remove_conflicting_framebuffers(struct apertures_struct *a,
 			(primary && gen_aper && gen_aper->count &&
 			 gen_aper->ranges[0].base = VGA_FB_PHYS)) {
 
-			printk(KERN_INFO "fb: conflicting fb hw usage "
-			       "%s vs %s - removing generic driver\n",
+			printk(KERN_INFO "fb: switching to %s from %s\n",
 			       name, registered_fb[i]->fix.id);
 			do_unregister_framebuffer(registered_fb[i]);
 		}
-- 
1.7.7.6

[PATCH] fbdev: Make the switch from generic to native driver less alarming

From: Adam Jackson <hidden>
Date: 2014-02-12 21:02:02

Calling this "conflicting" just makes people think there's a problem
when there's not.

Signed-off-by: Adam Jackson <redacted>
---
 drivers/video/fbmem.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 7309ac7..b6d5008 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1596,8 +1596,7 @@ static int do_remove_conflicting_framebuffers(struct apertures_struct *a,
 			(primary && gen_aper && gen_aper->count &&
 			 gen_aper->ranges[0].base = VGA_FB_PHYS)) {
 
-			printk(KERN_INFO "fb: conflicting fb hw usage "
-			       "%s vs %s - removing generic driver\n",
+			printk(KERN_INFO "fb: switching to %s from %s\n",
 			       name, registered_fb[i]->fix.id);
 			ret = do_unregister_framebuffer(registered_fb[i]);
 			if (ret)
-- 
1.8.5.3

Re: [PATCH] fbdev: Make the switch from generic to native driver less alarming

From: David Herrmann <hidden>
Date: 2014-03-16 16:40:03

Hi

CC'ing Tomi.

On Wed, Feb 12, 2014 at 10:02 PM, Adam Jackson [off-list ref] wrote:
quoted hunk
Calling this "conflicting" just makes people think there's a problem
when there's not.

Signed-off-by: Adam Jackson <redacted>
---
 drivers/video/fbmem.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 7309ac7..b6d5008 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1596,8 +1596,7 @@ static int do_remove_conflicting_framebuffers(struct apertures_struct *a,
                        (primary && gen_aper && gen_aper->count &&
                         gen_aper->ranges[0].base = VGA_FB_PHYS)) {

-                       printk(KERN_INFO "fb: conflicting fb hw usage "
-                              "%s vs %s - removing generic driver\n",
+                       printk(KERN_INFO "fb: switching to %s from %s\n",
                               name, registered_fb[i]->fix.id);
I like that.

Reviewed-by: David Herrmann <redacted>

Thanks
David
                        ret = do_unregister_framebuffer(registered_fb[i]);
                        if (ret)
--
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fbdev: Make the switch from generic to native driver less alarming

From: Tomi Valkeinen <hidden>
Date: 2014-03-21 13:42:42

On 12/02/14 23:02, Adam Jackson wrote:
quoted hunk
Calling this "conflicting" just makes people think there's a problem
when there's not.

Signed-off-by: Adam Jackson <redacted>
---
 drivers/video/fbmem.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 7309ac7..b6d5008 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1596,8 +1596,7 @@ static int do_remove_conflicting_framebuffers(struct apertures_struct *a,
 			(primary && gen_aper && gen_aper->count &&
 			 gen_aper->ranges[0].base == VGA_FB_PHYS)) {
 
-			printk(KERN_INFO "fb: conflicting fb hw usage "
-			       "%s vs %s - removing generic driver\n",
+			printk(KERN_INFO "fb: switching to %s from %s\n",
 			       name, registered_fb[i]->fix.id);
 			ret = do_unregister_framebuffer(registered_fb[i]);
 			if (ret)
Thanks, queued for 3.15.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help