Thread (2 messages) 2 messages, 2 authors, 2012-08-20

Re: [PATCH 09/10] video: exynos_dp: Fix bug when checking dp->irq

From: Jingoo Han <hidden>
Date: 2012-08-20 09:24:42

On Wednesday, August 08, 2012 12:54 PM Sean Paul wrote:
-----Original Message-----
From: Sean Paul [mailto:seanpaul@chromium.org]
Sent: Wednesday, August 08, 2012 12:54 PM
To: jg1.han@samsung.com; linux-fbdev@vger.kernel.org
Cc: Sean Paul
Subject: [PATCH 09/10] video: exynos_dp: Fix bug when checking dp->irq

Fix a bug where we check !dp->irq instead of the correct check for
-ENXIO.

BUG=None
TEST=None

Change-Id: Ibcdd16fb71eb41e4380ac8911ad6063634ff80e2
Remove unnecessary commit message such as 'Change-Id',
'BUG', and 'TEST'.

quoted hunk ↗ jump to hunk
Signed-off-by: Sean Paul <redacted>
Reviewed-on: https://gerrit.chromium.org/gerrit/29144
Reviewed-by: Olof Johansson <redacted>
---
 drivers/video/exynos/exynos_dp_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c
index 68ad494..eb5816f 100644
--- a/drivers/video/exynos/exynos_dp_core.c
+++ b/drivers/video/exynos/exynos_dp_core.c
@@ -919,7 +919,7 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev)
 	}

 	dp->irq = platform_get_irq(pdev, 0);
-	if (!dp->irq) {
+	if (dp->irq = -ENXIO) {
 		dev_err(&pdev->dev, "failed to get irq\n");
 		ret = -ENODEV;
 		goto err_clock;
--
1.7.7.3
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help