Re: [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step

Hi Morimoto-san,

On Sunday 29 July 2012 18:25:59 Kuninori Morimoto wrote:

quoted

diff --git a/drivers/video/sh_mobile_lcdcfb.c

b/drivers/video/sh_mobile_lcdcfb.c index 8cb653b..699487c 100644

--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c

@@ -1716,11 +1716,11 @@ sh_mobile_lcdc_overlay_fb_init(struct

sh_mobile_lcdc_overlay *ovl)> 
 		info->fix.visual = FB_VISUAL_TRUECOLOR;
 	
 	switch (ovl->format->fourcc) {

-	case V4L2_PIX_FMT_NV16:
-	case V4L2_PIX_FMT_NV61:
-		info->fix.ypanstep = 2;
 	case V4L2_PIX_FMT_NV12:
 	case V4L2_PIX_FMT_NV21:
+		info->fix.ypanstep = 2;
+	case V4L2_PIX_FMT_NV16:
+	case V4L2_PIX_FMT_NV61:
 		info->fix.xpanstep = 2;
 	}

@@ -2215,11 +2215,11 @@ sh_mobile_lcdc_channel_fb_init(struct

sh_mobile_lcdc_chan *ch,
 		info->fix.visual = FB_VISUAL_TRUECOLOR;
 	
 	switch (ch->format->fourcc) {
-	case V4L2_PIX_FMT_NV16:
-	case V4L2_PIX_FMT_NV61:
-		info->fix.ypanstep = 2;
 	case V4L2_PIX_FMT_NV12:
 	case V4L2_PIX_FMT_NV21:
+		info->fix.ypanstep = 2;
+	case V4L2_PIX_FMT_NV16:
+	case V4L2_PIX_FMT_NV61:
 		info->fix.xpanstep = 2;
 	}

If possible, could you please add comment /* fall through */ ?
current code is a little bit confusing

I'm afraid the code has already been pushed to v3.6-rc1 :-S

-- 
Regards,

Laurent Pinchart