Thread (13 messages) 13 messages, 5 authors, 2012-08-23

Re: [PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions

From: Damien Cassou <hidden>
Date: 2012-07-31 16:02:13
Also in: kernel-janitors, lkml 

The whole patch is incorrect because of:

On Tue, Jul 31, 2012 at 5:47 PM, Sachin Kamat [off-list ref] wrote:
quoted
-       ret = request_irq(par->irq, lcdc_irq_handler, 0,
-                       DRIVER_NAME, par);
+       ret = devm_request_irq(&device->dev, par->irq, lcdc_irq_handler, 0,
+                              DRIVER_NAME, par);
The following message explains why this is problematic:
http://marc.info/?l=kernel-janitors&m4374464625591&w=2

Please ignore this whole patch altogether.

Sorry about that.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Lambdas are relegated to relative obscurity until Java makes them
popular by not having them." James Iry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help