Re: [PATCH 0/7] HID: picoLCD updates
From: Bruno Prémont <bonbons@linux-vserver.org>
Date: 2012-07-31 07:59:15
Also in:
linux-input, lkml
Hi David, On Tue, 31 Jul 2012 09:26:07 David Herrmann wrote:
This is not directly related to this patchset, but did you fix the locking issue with hid-core? It is still on my todo-list but I haven't gotten around fixing it, yet. However, I plan on fixing it this summer, but if picolcd does not require it, it's probably not worth the work.
I worked around it with patch 6/7 as in disabling the version check. The other probing steps don't expect a response from the hardware, thus are not affected. But it would definitely be helpful to be able to revert that one. Understanding and fixing the FB-related misbehavior on quick bind/unbind seems more important though. Not related with this, getting a return value from usbhid_submit_report() as in -EAGAIN or -ENODEV would help in order to avoid the ugly hid-picolcd 0003:04D8:C002.0003: usb_submit_urb(out) failed: -19 lines in kernel log and stopping interaction with hardware when it's gone already or giving it time to consume its queue when there is lots of data being sent. Regards, Bruno