Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer

Hi Joe

On Mon, Jul 9, 2012 at 12:13 AM, Joe Perches [off-list ref] wrote:

On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote:

quoted

Hi David.  Trivial comments only:

quoted

diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c

[]

quoted

@@ -23,15 +23,204 @@
  * all fblog instances before running other graphics applications.
  */

Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and...

Thanks, I've added it.

quoted

 static int __init fblog_init(void)
 {
+     int ret;
+
+     ret = fb_register_client(&fblog_notifier);
+     if (ret) {
+             pr_err("fblog: cannot register framebuffer notifier");

Missing newline, pr_fmt would add module name.

                pr_err("cannot register framebuffer notifier\n");

Fixed, too. Thanks!
David