Re: [PATCH] mbxfb: unbreak compilation with CONFIG_FB_MBX_DEBUG
From: Eric Miao <hidden>
Date: 2012-05-16 00:20:57
Also in:
lkml
On Tue, May 15, 2012 at 12:31 AM, [off-list ref] wrote:
From: Reinhard Tartler <redacted> This patch adds missing function prototypes. Signed-off-by: Reinhard Tartler <redacted> --- drivers/video/mbx/mbxfb.c | 3 +++ 1 file changed, 3 insertions(+) This patch was found with tools developed in the VAMOS project: http://www4.cs.fau.de/Research/VAMOS/ TBH, I'm not sure if this is the correct solution. However, I'd appreciate if someone could confirm that this is a real bug.
This looks to be a correct solution to me. Acked-by: Eric Miao <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c index 6ce3416..c2200ec 100644 --- a/drivers/video/mbx/mbxfb.c +++ b/drivers/video/mbx/mbxfb.c@@ -878,6 +878,9 @@ static int mbxfb_resume(struct platform_device *dev)#ifndef CONFIG_FB_MBX_DEBUG #define mbxfb_debugfs_init(x) do {} while(0) #define mbxfb_debugfs_remove(x) do {} while(0) +#else +void mbxfb_debugfs_init(struct fb_info *fbi); +void mbxfb_debugfs_remove(struct fb_info *fbi); #endif #define res_size(_r) (((_r)->end - (_r)->start) + 1) -- 1.7.9.5