Thread (55 messages) 55 messages, 3 authors, 2012-05-09

Re: [PATCH v4 0/9] OMAPDSS: APPLY: Treat overlay manager timings as shadow registers

From: Tomi Valkeinen <hidden>
Date: 2012-05-09 11:51:29
Also in: linux-omap

On Wed, 2012-05-09 at 16:54 +0530, Archit Taneja wrote:
On Wednesday 09 May 2012 04:43 PM, Tomi Valkeinen wrote:
quoted
On Wed, 2012-05-09 at 15:40 +0530, Archit Taneja wrote:
quoted
An overlay manager's timings (the manager size, and blanking parameters if an
LCD manager) are DISPC shadow registers, and they should hence follow the
correct programming model.

This set makes the timings an extra_info parameter in manager's private data .
The interface drivers now apply the timings in instead of directly writing to
registers.

This change also prevents the need to use display resolution for overlay
checks, hence making some of the APPLY functions less dependent on the display.
Some DISPC functions that needed display width can also use these privately
stored timings.

Changes since v3:

- Remove direct setting of go bit in dpi_set_timings()
- Take some of the patches in "OMAPDSS: Misc fixes and cleanups" and make them a
   part of this series as they are more related.
- Don't have an initial set of manager timings in private data, only check
   manager and overlay parameters once the manager is enabled.

These patches apply over:

git://gitorious.org/linux-omap-dss2/linux.git dev

Reference tree containing this series:

git://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone.git mgr_timing_and_fixes_2

Tested on OMAP4 SDP and Panda.
I did some quick tests on omap3 overo, worked fine. I'll merge to dss
master branch.
Russ did some tests on more omap3 boards, the tree which he used has 
some slight changes comapred to what I have posted, but it's more or 
less the same.

Could you add 'Tested-by: Russ.Dill@ti.com' if not too difficult, I 
missed out doing that.
Sorry, I could, but I already merged and pushed the series, so I can't
change it anymore.

 Tomi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help