Thread (3 messages) 3 messages, 3 authors, 2012-04-28

[PATCH] drivers/video/xen-fbfront.c: add missing cleanup code

STALE5272d

From: Julia Lawall <hidden>
Date: 2012-04-22 09:57:51
Also in: kernel-janitors, lkml, xen-devel
Subsystem: framebuffer layer, the rest, xen hypervisor interface · Maintainers: Helge Deller, Linus Torvalds, Juergen Gross, Stefano Stabellini

From: Julia Lawall <redacted>

The operations in the subsequent error-handling code appear to be also
useful here.

Signed-off-by: Julia Lawall <redacted>

---
Not tested.

 drivers/video/xen-fbfront.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c
index cb4529c..b0bd59c 100644
--- a/drivers/video/xen-fbfront.c
+++ b/drivers/video/xen-fbfront.c
@@ -458,8 +458,13 @@ static int __devinit xenfb_probe(struct xenbus_device *dev,
 	xenfb_init_shared_page(info, fb_info);
 
 	ret = xenfb_connect_backend(dev, info);
-	if (ret < 0)
+	if (ret < 0) {
+		fb_deferred_io_cleanup(fb_info);
+		fb_dealloc_cmap(&fb_info->cmap);
+		framebuffer_release(fb_info);
+		xenbus_dev_fatal(dev, ret, "xenfb_connect_backend");
 		goto error;
+	}
 
 	ret = register_framebuffer(fb_info);
 	if (ret) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help