[PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release

Subsystems: framebuffer layer, the rest

STALE5205d

2 messages, 2 authors, 2012-05-13 · open the first message on its own page

[PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release

From: Julia Lawall <hidden>
Date: 2012-04-19 16:56:03

From: Julia Lawall <redacted>

Release bridge, as done on all other paths out of the function.

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/intelfb/intelfbdrv.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index 02fd226..bdcbfba 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c

@@ -680,6 +680,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 		 + dinfo->fb.size);
 	if (!dinfo->aperture.virtual) {
 		ERR_MSG("Cannot remap FB region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}

@@ -689,6 +690,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 					      INTEL_REG_SIZE);
 	if (!dinfo->mmio_base) {
 		ERR_MSG("Cannot remap MMIO region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}

Re: [PATCH] drivers/video/intelfb/intelfbdrv.c: add missing agp_backend_release

From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2012-05-13 20:51:03

On 04/19/2012 04:55 PM, Julia Lawall wrote:

From: Julia Lawall <redacted>

Release bridge, as done on all other paths out of the function.

Signed-off-by: Julia Lawall <redacted>

Looks good to me, applied.


Thanks,

Florian Tobias Schandinat

quoted hunk

---
 drivers/video/intelfb/intelfbdrv.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index 02fd226..bdcbfba 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c

@@ -680,6 +680,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 		 + dinfo->fb.size);
 	if (!dinfo->aperture.virtual) {
 		ERR_MSG("Cannot remap FB region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}

@@ -689,6 +690,7 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 					      INTEL_REG_SIZE);
 	if (!dinfo->mmio_base) {
 		ERR_MSG("Cannot remap MMIO region.\n");
+		agp_backend_release(bridge);
 		cleanup(dinfo);
 		return -ENODEV;
 	}

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help