Re: [PATCH 0/3] video: s3c-fb: Rearrange the elements in platform data

On 5 March 2012 12:59, Jingoo Han [off-list ref] wrote:

quoted

-----Original Message-----
From: Thomas Abraham [mailto:thomas.abraham@linaro.org]
Sent: Sunday, March 04, 2012 12:50 AM
To: linux-fbdev@vger.kernel.org
Cc: FlorianSchandinat@gmx.de; linux-samsung-soc@vger.kernel.org; kgene.kim@samsung.com;
jg1.han@samsung.com; ben-linux@fluff.org; patches@linaro.org
Subject: [PATCH 0/3] video: s3c-fb: Rearrange the elements in platform data

This patchset rearranges the elements in the platform data of the s3c-fb
driver with the intent of adding device tree support to the driver in
subsequent patches.

The first patch moves the video timing information from the individual window
setup data into the platform specific configuration section in the platform
data. The video timing is independent of the window setup. The resolution of
the window could be smaller than that of the lcd panel attached. So the video
timing data is removed from window configuration data.

Hi, Thomas.

OK, I know what you have done.
Actually, it was my long concern.

Current s3c-fb driver needs lcd panel resolutions, since each window's
xres, yres values can be changed by fb driver or user application.
Therefore, additional 'costant' lcd panel resolutions are necessary in order to
set timing values.

I'll review your patch.
Thank you.

Thanks. Please let me know if you have any comments.

Regards,
Thomas.

[...]