Re: [PATCH 01/21] OMAPDSS: panel-dvi: add PD gpio handling

On Wed, 2012-03-07 at 23:17 +0530, Archit Taneja wrote:

Hi,

On Wednesday 07 March 2012 06:14 PM, Tomi Valkeinen wrote:

quoted

The driver for the DVI framer should handle the power-down signal of the
framer, instead of the current way of handling it in the board files.

What does framer mean?

I don't know where the word has come, and I can't find it in the TFP410
documentation. I guess the idea with the word was that the chip
"frames", i.e. packetizes, the incoming parallel data to DVI.

But I think it's better to remove the use of the word to avoid any
confusion. I'll make the change.

quoted

+	if (gpio_is_valid(ddata->pd_gpio)) {
+		r = gpio_request_one(ddata->pd_gpio, GPIOF_OUT_INIT_LOW,
+				"tfp410 pd");
+		if (r) {
+			dev_err(&dssdev->dev, "Failed to request PD GPIO %d\n",
+					ddata->pd_gpio);
+			ddata->pd_gpio = -1;

Is the power down gpio not a necessary thing? If it is, we should quit 
here itself, shouldn't we?

Hmm, yes, I think you are right.

 Tomi