Re: [PATCH V2 2/3] OMAPDSS: DISPC: Handle synclost errors in OMAP3

On Tue, 2012-03-27 at 16:31 +0530, Mahapatra, Chandrabhanu wrote:

On Tue, Mar 27, 2012 at 4:13 PM, Tomi Valkeinen [off-list ref] wrote:

quoted

Hi,

On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote:

quoted

In OMAP3 DISPC video overlays suffer from some undocumented horizontal position
and timing related limitations leading to SYNCLOST errors. Whenever the image
window is moved towards the right of the screen SYNCLOST errors become
frequent. Checks have been implemented to see that DISPC driver rejects
configuration exceeding above limitations.

This code was successfully tested on OMAP3. This code is written based on code
written by Ville Syrjälä [off-list ref] in Linux OMAP kernel. Ville
Syrjälä [off-list ref] had added checks for video overlay horizontal
timing and DISPC horizontal blanking length limitations.

Signed-off-by: Chandrabhanu Mahapatra <redacted>
---
 drivers/video/omap2/dss/dispc.c |   97 +++++++++++++++++++++++++++++----------
 1 files changed, 72 insertions(+), 25 deletions(-)

The patch seems to be using dos line endings... Where did they come
from? The two others are fine. I think git am removed the dos line
endings, so it's fine.

How did you find these errors? scripts/checkpatch.pl still returns me nothing.

Well I just saved the email and ran checkpatch. Could be a problem in
gmail or my end too, but I've never seen it happen before.

 Tomi