RE: [patch] backlight: s6e63m0: corruption storing gamma mode
From: Inki Dae <inki.dae@samsung.com>
Date: 2012-03-05 01:20:02
Also in:
kernel-janitors
Acked-by: Inki Dae <inki.dae@samsung.com> Thanks.
quoted hunk ↗ jump to hunk
-----Original Message----- From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev- owner@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Friday, March 02, 2012 3:56 PM To: Richard Purdie; InKi Dae Cc: Florian Tobias Schandinat; linux-fbdev@vger.kernel.org; kernel- janitors@vger.kernel.org Subject: [patch] backlight: s6e63m0: corruption storing gamma mode strict_strtoul() writes a long but ->gamma_mode only has space to store an int, so on 64 bit systems we end up scribbling over ->gamma_table_count as well. I've changed it to use kstrtouint() instead. Signed-off-by: Dan Carpenter <redacted>diff --git a/drivers/video/backlight/s6e63m0.cb/drivers/video/backlight/s6e63m0.c index 9b0092e..e264f55 100644--- a/drivers/video/backlight/s6e63m0.c +++ b/drivers/video/backlight/s6e63m0.c@@ -690,7 +690,7 @@ static ssize_t s6e63m0_sysfs_store_gamma_mode(structdevice *dev, struct backlight_device *bd = NULL; int brightness, rc; - rc = strict_strtoul(buf, 0, (unsigned long *)&lcd->gamma_mode); + rc = kstrtouint(buf, 0, &lcd->gamma_mode); if (rc < 0) return rc; -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html