Re: [PATCH] udlfb: Fix invalid return codes in edid sysfs entry store function
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2012-02-28 16:14:03
[Cc'ing Bernie Thompson, the udlfb maintainer] @Bernie: Why don't you add an entry for it in MAINTAINERS? On 02/23/2012 07:53 AM, Olivier Sobrie wrote:
quoted hunk ↗ jump to hunk
Return a negative errno instead of zero in the write function of the sysfs entry in case of error. Also add a check on the return value of dlfb_setup_modes(). Signed-off-by: Olivier Sobrie <redacted> --- drivers/video/udlfb.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index a197731..abbc3fe 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c@@ -1427,19 +1427,22 @@ static ssize_t edid_store( struct device *fbdev = container_of(kobj, struct device, kobj); struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dev = fb_info->par; + int ret; /* We only support write of entire EDID at once, no offset*/ if ((src_size != EDID_LENGTH) || (src_off != 0)) - return 0; + return -EINVAL; - dlfb_setup_modes(dev, fb_info, src, src_size); + ret = dlfb_setup_modes(dev, fb_info, src, src_size); + if (ret) + return ret; if (dev->edid && (memcmp(src, dev->edid, src_size) = 0)) { pr_info("sysfs written EDID is new default\n"); dlfb_ops_set_par(fb_info); return src_size; } else - return 0; + return -EINVAL; } static ssize_t metrics_reset_store(struct device *fbdev,