Re: [PATCH 1/2] OMAPDSS: panel-dvi: Add Kconfig dependency on I2C
flat view
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2012-02-29 10:03:45
Also in:
linux-omap
On 02/29/2012 08:48 AM, Tomi Valkeinen wrote:
quoted hunk ↗ jump to hunk
panel-dvi uses i2c, but the Kconfig didn't have dependency on I2C. Add it. Signed-off-by: Tomi Valkeinen <redacted> --- drivers/video/omap2/displays/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/video/omap2/displays/Kconfig b/drivers/video/omap2/displays/Kconfig index 74d29b5..408a992 100644 --- a/drivers/video/omap2/displays/Kconfig +++ b/drivers/video/omap2/displays/Kconfig@@ -12,7 +12,7 @@ config PANEL_GENERIC_DPI config PANEL_DVI tristate "DVI output" - depends on OMAP2_DSS_DPI + depends on OMAP2_DSS_DPI && I2C
It's just a matter of taste, but are you sure you want to "depend" on it and not "select" it? Other drivers tend to use select for I2C, for me it doesn't really matter. Best regards, Florian Tobias Schandinat
help Driver for external monitors, connected via DVI. The driver uses i2c to read EDID information from the monitor.